Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ibm cloud provider use go module #235

Closed
jichenjc opened this issue Jun 12, 2019 · 10 comments · Fixed by #283
Closed

Refactor ibm cloud provider use go module #235

jichenjc opened this issue Jun 12, 2019 · 10 comments · Fixed by #283
Assignees
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jichenjc
Copy link
Contributor

jichenjc commented Jun 12, 2019

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md
noticed this, should we follow this or keep using dep or take this a future action?

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/ibmcloud Issues or PRs related to ibmcloud provider labels Jun 12, 2019
@xunpan
Copy link
Contributor

xunpan commented Jun 12, 2019

I think keep consistent with cluster-api is fine.
go module should be future direction as it is official go dependecy management tool. However, currently, there is no painpoint for using dep in ibm cloud provider. When cluster-api switch its dependecy management tool. We can follow it up.

@jichenjc jichenjc added the future Future Works label Jun 12, 2019
@jichenjc
Copy link
Contributor Author

ok, let's take this as future item

@gyliu513
Copy link
Contributor

cluster api is working for this kubernetes-sigs/cluster-api#1054 (comment)

@jichenjc
Copy link
Contributor Author

Thanks, I am looking at it and hopefully to replicate to here soon...

@jichenjc
Copy link
Contributor Author

/assign

let me try this

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2019
@gyliu513
Copy link
Contributor

/remove-lifecycle stale

@jichenjc do you still have plan to work for this? I think we need to take this as priority now.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2019
@gyliu513 gyliu513 removed the future Future Works label Sep 26, 2019
@gyliu513 gyliu513 changed the title [question] go modules usage Refactor ibm cloud provider use go module Sep 26, 2019
@k8s-ci-robot
Copy link
Contributor

@jichenjc: The label(s) sig/ibmcloud cannot be applied. These labels are supported: api-review, community/discussion, community/maintenance, community/question, cuj/build-train-deploy, cuj/multi-user, platform/aws, platform/azure, platform/gcp, platform/minikube, platform/other

In response to this:

/kind feature
/sig ibmcloud

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md
noticed this, should we follow this or keep using dep or take this a future action?

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jichenjc jichenjc removed their assignment Sep 26, 2019
@jichenjc
Copy link
Contributor Author

@gyliu513 I am buried in some other stuffs recently, so unassign myself and let's see anyone can help on this, thanks for the reminder

@gyliu513
Copy link
Contributor

/assign

Thanks @jichenjc for the heads up, let me check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/ibmcloud Issues or PRs related to ibmcloud provider kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants