-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kube-vip spec in cluster templates to adopt k8s 1.29 #1798
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be temporary fix, but we need to assess this for log run.
see comment kube-vip/kube-vip#684 (comment) for more information.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mkumatag, should we back port this to release-0.8 branch? |
I feel not required, we aren't testing that branch aggressively! |
What this PR does / why we need it:
kube-vip has issues when being used with k8s 1.29. This PR fixes them by
kubeadm
to provision a separate Kubeconfig file calledsuper-admin.conf
and reducing theadmin.conf
User's access to the permissions provided by the cluster-admin ClusterRole. It is to be noted that in a multi-cluster setup, thesuper-admin.conf
is only created on the primary control plane node, which runskubeadm init
is failing because kube-vip deployment is hardcoded to useadmin.conf
but kube-vip requires elevated permissions to access the API server during cluster initialization, which are available only when using thesuper-admin.conf
.hostAliases
do not work as expected. Add a work around to mount the volumes to thekube-vip
pod manifest.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1792
Special notes for your reviewer:
/area provider/ibmcloud
Release note: