Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UT for ReconcileNetwork and its subfunctions #1928

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add UT for ReconcileNetwork and its subfunctions #1928

merged 1 commit into from
Oct 25, 2024

Conversation

Shilpa-Gokul
Copy link
Contributor

@Shilpa-Gokul Shilpa-Gokul commented Aug 22, 2024 •
edited
Loading

Add UT for ReconcileNetwork, getNetwork, isDHCPServerActive, checkDHCPServerStatus & createDHCPServer function
Partially fixes #1818

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Amulyam24 August 22, 2024 05:33
@k8s-ci-robot
Copy link
Contributor

Hi @Shilpa-Gokul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 7b5c08b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/671b981e5001fe000828eee9
😎 Deploy Preview https://deploy-preview-1928--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Amulyam24
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
Amulyam24
Amulyam24 reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shilpa-Gokul!

It would also be good to cover the scenario where DHCP server exists and returns without error

cloud/scope/powervs_cluster_test.go Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
@Karthik-K-N Karthik-K-N mentioned this pull request Sep 17, 2024
Closed
2 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 10, 2024
@Shilpa-Gokul Shilpa-Gokul reopened this Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2024
@Shilpa-Gokul Shilpa-Gokul force-pushed the UT branch 2 times, most recently from 3966109 to 32e17c9 Compare October 17, 2024 06:32
@Prajyot-Parab
Copy link
Contributor

/cc @Karthik-K-N

@Shilpa-Gokul Shilpa-Gokul force-pushed the UT branch 2 times, most recently from 0ff2802 to 6963557 Compare October 23, 2024 08:50
@Shilpa-Gokul Shilpa-Gokul changed the title Add UT for ReconcileNetwork, getNetwork, isDHCPServerActive, checkDHCPServerStatus & createDHCPServer function Add UT for ReconcileNetwork and its subfunctions Oct 23, 2024
Amulyam24
Amulyam24 reviewed Oct 23, 2024
View reviewed changes
cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
Amulyam24
Amulyam24 reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, LGTM!

cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
@Shilpa-Gokul
Copy link
Contributor Author

@Prajyot-Parab @Amulyam24 @Karthik-K-N Have addressed all the comments, please take a look

Amulyam24
Amulyam24 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @Prajyot-Parab

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
Prajyot-Parab
Prajyot-Parab approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
Prajyot-Parab
Prajyot-Parab approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5e547ec into kubernetes-sigs:main Oct 25, 2024
13 checks passed
@Shilpa-Gokul Shilpa-Gokul deleted the UT branch October 28, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@Amulyam24 Amulyam24 Amulyam24 approved these changes

@Karthik-K-N Karthik-K-N Awaiting requested review from Karthik-K-N

Assignees

@Amulyam24 Amulyam24

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EPIC: Add UT accross various files in repository
4 participants
@Shilpa-Gokul @k8s-ci-robot @Amulyam24 @Prajyot-Parab