Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UT coverage for IBMPowerVSCluster deletion flow #2049

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Improve UT coverage for IBMPowerVSCluster deletion flow #2049

merged 1 commit into from
Nov 12, 2024

Conversation

Shilpa-Gokul
Copy link
Contributor

@Shilpa-Gokul Shilpa-Gokul commented Nov 12, 2024 •
edited
Loading

This PR covers UT for deleteTransitGatewayConnections, DeleteDHCPServer, DeleteServiceInstance, DeleteCOSInstance, isResourceCreatedByController functions

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1818

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Shilpa-Gokul. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 12, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 3193928
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6733646787a49d0008b2a30e
😎 Deploy Preview https://deploy-preview-2049--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2024
@Karthik-K-N
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2024
Karthik-K-N
Karthik-K-N reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for quickly submitting the PR
Overall LGTM
Lets update the error statements like powervs_cluster_controller.go file to keep it uniform and meaningfull

cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Show resolved Hide resolved
cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
@Amulyam24
Copy link
Contributor

/retitle Improve UT coverage for IBMPowerVSCluster deletion flow

@k8s-ci-robot k8s-ci-robot changed the title Add UT for powervs_cluster functions Improve UT coverage for IBMPowerVSCluster deletion flow Nov 12, 2024
Karthik-K-N
Karthik-K-N reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @Amulyam24

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
Amulyam24
Amulyam24 reviewed Nov 12, 2024
View reviewed changes
cloud/scope/powervs_cluster_test.go Outdated
teardown := func() {
mockCtrl.Finish()
}
t.Run("When cos instance resource is not created by controller", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Run("When cos instance resource is not created by controller", func(t *testing.T) {
t.Run("When COS instance resource is not created by controller", func(t *testing.T) {

Better to keep the names uniform throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

cloud/scope/powervs_cluster_test.go Outdated
t.Cleanup(teardown)

clusterScope := PowerVSClusterScope{IBMPowerVSCluster: &infrav1beta2.IBMPowerVSCluster{}}
isDeleted, err := clusterScope.DeleteServiceInstance()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isDeleted, err := clusterScope.DeleteServiceInstance()
requeue, err := clusterScope.DeleteServiceInstance()

Please change wherever applicable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

cloud/scope/powervs_cluster_test.go Outdated
teardown := func() {
mockCtrl.Finish()
}
t.Run("When transit gateway in PowerVS is in deleting state", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Run("When transit gateway in PowerVS is in deleting state", func(t *testing.T) {
t.Run("When PowerVS connection of transit gateway is in deleting state", func(t *testing.T) {

The test case name might cause confusion, please change it wherever applicable for this function to specify as PVS connection or VPC connection of a TG

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, changed the test names accordingly

cloud/scope/powervs_cluster_test.go Outdated
g.Expect(err.Error()).To(Equal("failed to get transit gateway powervs connection: error getting transit gateway connection"))
g.Expect(requeue).To(BeFalse())
})
t.Run("When transit gateway in PowerVS is not found", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Run("When transit gateway in PowerVS is not found", func(t *testing.T) {
t.Run("When PowerVS connection is not found and VPC connection is deleted successfully", func(t *testing.T) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

cloud/scope/powervs_cluster_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
Amulyam24
Amulyam24 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thank you @Shilpa-Gokul!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2024
Prajyot-Parab
Prajyot-Parab approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab, Shilpa-Gokul

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit f9aac2c into kubernetes-sigs:main Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@Amulyam24 Amulyam24 Amulyam24 approved these changes

Assignees

@Amulyam24 Amulyam24

@Karthik-K-N Karthik-K-N

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EPIC: Add UT accross various files in repository
5 participants
@Shilpa-Gokul @k8s-ci-robot @Karthik-K-N @Amulyam24 @Prajyot-Parab