Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [CP] Allow webhook changes to OpenStackCluster.Spec.Bastion #1075

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Dec 8, 2021

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1054
cherry-picks #1070

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese tobias.giese@daimler.com, Daimler TSS GmbH, legal info/Impressum

Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
…ebhooks

Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
Signed-off-by: Tobias Giese <tobias.giese@daimler.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2021
@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: dc6dc35

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61b06c518a210c000762a6bb

😎 Browse the preview: https://deploy-preview-1075--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tobiasgiese
To complete the pull request process, please assign justinsb after the PR has been reviewed.
You can assign the PR to them by writing /assign @justinsb in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tobiasgiese tobiasgiese changed the title Tobiasgiese/cherry pick bastion 1070 ✨ [CP] Allow webhook changes to OpenStackCluster.Spec.Bastion Dec 8, 2021
@tobiasgiese tobiasgiese closed this Dec 8, 2021
@tobiasgiese
Copy link
Member Author

tobiasgiese commented Dec 8, 2021

I got the wrong release branch 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants