Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Add apricote as a reviewer #1212

Merged
merged 1 commit into from
Apr 20, 2022
Merged

🏃 Add apricote as a reviewer #1212

merged 1 commit into from
Apr 20, 2022

Conversation

apricote
Copy link
Member

What this PR does / why we need it:

Add myself (@apricote) as a reviewer in the OWNER_ALIASES file. This was discussed in today's office hours.

The other files linked here only include maintainers, so I think there is no more work to be done after this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 20, 2022
@netlify
Copy link

netlify bot commented Apr 20, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 1aba6e6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/626019a223b7470008f7ad11
😎 Deploy Preview https://deploy-preview-1212--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2022
@tobiasgiese
Copy link
Member

/approve

Welcome to the team @apricote 🙂 really appreciate your contributions so far!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2022
@seanschneeweiss
Copy link
Contributor

/lgtm
Great to have you on board. Thanks for all your work.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit b580527 into kubernetes-sigs:main Apr 20, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Apr 21, 2022

/cherry-pick release-0.5

@k8s-infra-cherrypick-robot

@mdbooth: new pull request created: #1214

In response to this:

/cherry-pick release-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apricote apricote deleted the apricote-reviewer branch April 21, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants