-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix ginkgo warnings #1239
🌱 Fix ginkgo warnings #1239
Conversation
We were using some deprecated ginkgo functionality. Namely running tests asynchronously and using a custom reporter. This commit fixes those warnings by running the tests synchronously and using the standard reporter.
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @lentzi90. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As this is fairly trivial I'm also happy to |
What this PR does / why we need it:
We were using some deprecated ginkgo functionality. Namely running tests asynchronously and using a custom reporter.
This commit fixes those warnings by running the tests synchronously and
using the standard reporter.
Special notes for your reviewer:
TODOs: