Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 implement conversion for OpenStackClusterTemplate CRD #1249

Merged
merged 1 commit into from
May 25, 2022
Merged

🐛 implement conversion for OpenStackClusterTemplate CRD #1249

merged 1 commit into from
May 25, 2022

Conversation

apricote
Copy link
Member

What this PR does / why we need it:

Adds Hub() methods to v1alpha5 OpenStackClusterTemplate struct and implements Convertible interface in v1alpha4. API was only introduced in v1alpha4, so conversion to/from v1alpha3 is not needed.

conversion-gen already generated the automatic conversion functions.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1248

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 25, 2022
@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit da47b8a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/628e0013fdb31100083b1190
😎 Deploy Preview https://deploy-preview-1249--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 25, 2022
@apricote
Copy link
Member Author

This blocks upgrading to CAPO v0.6 for us and anyone else using ClusterClass in v0.5.

/cherry-pick release-0.6

@k8s-infra-cherrypick-robot

@apricote: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you.

In response to this:

This blocks upgrading to CAPO v0.6 for us and anyone else using ClusterClass in v0.5.

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tobiasgiese
Copy link
Member

/approve
/lgtm

Thanks for this fast bugfix! 👍🏻 💯

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apricote, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 25, 2022
@apricote
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit c29befe into kubernetes-sigs:main May 25, 2022
@k8s-infra-cherrypick-robot

@apricote: new pull request created: #1250

In response to this:

This blocks upgrading to CAPO v0.6 for us and anyone else using ClusterClass in v0.5.

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apricote apricote deleted the conversion-clusterclass branch May 25, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversion for OpenStackClusterTemplate is missing (v1alpha4 -> v1alpha5, ClusterClass)
4 participants