-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 implement conversion for OpenStackClusterTemplate CRD #1249
🐛 implement conversion for OpenStackClusterTemplate CRD #1249
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This blocks upgrading to CAPO v0.6 for us and anyone else using ClusterClass in v0.5. /cherry-pick release-0.6 |
@apricote: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve Thanks for this fast bugfix! 👍🏻 💯 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apricote, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@apricote: new pull request created: #1250 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Adds
Hub()
methods tov1alpha5
OpenStackClusterTemplate
struct and implementsConvertible
interface inv1alpha4
. API was only introduced inv1alpha4
, so conversion to/fromv1alpha3
is not needed.conversion-gen
already generated the automatic conversion functions.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1248
/hold