🐛 delete port left over by err openstackmachine

[ruifaling]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1254

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	356469b
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62b2c9633f8c3c0008bd923c
😎 Deploy Preview	https://deploy-preview-1260--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

Hi @ruifaling. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tobiasgiese]

/ok-to-test

Thanks for contributing @ruifaling 🙂
Could you please link #1254 in your PR description?

[tobiasgiese]

/retitle 🐛 delete port left over by err openstackmachine

[tobiasgiese]

@ruifaling according to the pull-cluster-api-provider-openstack-test you should check the linter errors

pkg/cloud/services/networking/network.go:20: File is not `gofumpt`-ed (gofumpt)
	"fmt"
pkg/cloud/services/networking/network.go:22: File is not `gofumpt`-ed (gofumpt)
	"strings"
pkg/cloud/services/networking/network.go:21: File is not `goimports`-ed (goimports)
	capoerrors "sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors"
pkg/cloud/services/networking/network.go:154:2: var-naming: var networkId should be networkID (revive)
	networkId := openStackCluster.Spec.Network.ID
	^
pkg/cloud/services/networking/network.go:172:60: ST1017: don't use Yoda conditions (stylecheck)
		if strings.Contains(port.Name, openStackCluster.Name) && "" == port.DeviceOwner {
		                                                         ^

[ruifaling]

@ruifaling according to the pull-cluster-api-provider-openstack-test you should check the linter errors

pkg/cloud/services/networking/network.go:20: File is not `gofumpt`-ed (gofumpt)
	"fmt"
pkg/cloud/services/networking/network.go:22: File is not `gofumpt`-ed (gofumpt)
	"strings"
pkg/cloud/services/networking/network.go:21: File is not `goimports`-ed (goimports)
	capoerrors "sigs.k8s.io/cluster-api-provider-openstack/pkg/utils/errors"
pkg/cloud/services/networking/network.go:154:2: var-naming: var networkId should be networkID (revive)
	networkId := openStackCluster.Spec.Network.ID
	^
pkg/cloud/services/networking/network.go:172:60: ST1017: don't use Yoda conditions (stylecheck)
		if strings.Contains(port.Name, openStackCluster.Name) && "" == port.DeviceOwner {
		                                                         ^

I have fixed the pull-cluster-api-provider-openstack-test failed, and I am not very clear about the relationship between the pull-cluster-api-provider-openstack-e2e-test failures and my commit

[ruifaling]

@tobiasgiese I have fixed it,please review it again

[seanschneeweiss]

Thank you very much @ruifaling for the fix.

Can you move the code added to pkg/cloud/services/networking/network.go to the file pkg/cloud/services/networking/port.go?

[ruifaling]

@tobiasgiese @seanschneeweiss Are there any other errors I need to correct or Is there anything others need I to do?

[apricote]

/lgtm

[ruifaling]

need I remove the lable hold？

[tobiasgiese]

/approve
/hold cancel

sorry for the delay @ruifaling, missed your PR 🙂

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruifaling, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ruifaling]

is thers something wrong with the e2e test?