update doc to reflect latest version, add helm link #1275
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
|
||
| ```shell | ||
| curl https://docs.projectcalico.org/v3.19/manifests/calico.yaml | sed "s/veth_mtu:.*/veth_mtu: \"1430\"/g" | kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig apply -f - | ||
| curl https://docs.projectcalico.org/v3.23/manifests/calico.yaml | kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig apply -f - |
There was a problem hiding this comment.
Is there a reason why the lower veth_mtu is no longer required?
There was a problem hiding this comment.
curl https://docs.projectcalico.org/v3.23/manifests/calico.yaml
I checked the yaml itself says 0 (by default) it's will auto detect it ..I think we should let CNI detect
and at least I can deploy a cluster with such setting ..
There was a problem hiding this comment.
In this case you're able to
| curl https://docs.projectcalico.org/v3.23/manifests/calico.yaml | kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig apply -f - | |
| kubectl --kubeconfig=./${CLUSTER_NAME}.kubeconfig apply -f https://docs.projectcalico.org/v3.23/manifests/calico.yaml |
There was a problem hiding this comment.
FWIW I just changed the veth_mtu on my test cluster to "0" and everything still works.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
update doc to reflect latest version, add helm link
What this PR does / why we need it:
update doc for external cloud provider ...
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold