not assign floating ip when there are multiple controller nodes #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jichenjc
force-pushed
the
bug/1265
branch
2 times, most recently
from
16e7586 to
8b5c5d3
Compare
| @@ -153,6 +153,12 @@ openstack floating ip create <public network> | |||
|
|
|||
| Note: Only user with admin role can create a floating IP with specific IP. | |||
|
|
|||
| Note: When associate floating ip to a cluster with more than 1 controller nodes, the floating ip will be | |||
There was a problem hiding this comment.
Suggested change
| Note: When associate floating ip to a cluster with more than 1 controller nodes, the floating ip will be | |
| Note: When associating a floating IP to a cluster with more than 1 controller node, the floating IP will be |
| @@ -153,6 +153,12 @@ openstack floating ip create <public network> | |||
|
|
|||
| Note: Only user with admin role can create a floating IP with specific IP. | |||
|
|
|||
| Note: When associate floating ip to a cluster with more than 1 controller nodes, the floating ip will be | |||
| associated to the first controller node and the other controller nodes doesn't have floating ip. When | |||
There was a problem hiding this comment.
Suggested change
| associated to the first controller node and the other controller nodes doesn't have floating ip. When | |
| associated to the first controller node and the other controller nodes have no floating IP assigned. When |
jichenjc
force-pushed
the
bug/1265
branch
2 times, most recently
from
00d20f1 to
297620f
Compare
apricote
reviewed
Jul 11, 2022
| // assign to portID, so it's already assigned and no need action | ||
| // the other is fp.PortID assigned to another fixed ip (the other control plane) | ||
| // so no actions for both situations | ||
| if len(fp.PortID) != 0 { |
There was a problem hiding this comment.
What do you think about doing this check in the machine reconciler instead, because networking.Service#AssociateFloatingIP is also called from other locations where we potentially want to reassign the FIP, even if it is already assigned to another port
There was a problem hiding this comment.
yes, updated ,thanks~
|
@apricote please help check whether current way is better.. thanks |
|
/lgtm The commit looks like a merge commit, might want to take a look at that. |
k8s-ci-robot
added
the
lgtm
not sure what's a merge commit?? |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
k8s-ci-robot
added
size/M
tobiasgiese
reviewed
Jul 25, 2022
tobiasgiese
reviewed
Jul 25, 2022
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1265
Special notes for your reviewer:
TODOs:
/hold