✨ Add re-creation of bastion host on change #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
tobiasgiese
force-pushed
the
tobiasgiese/bastion-recreation
branch
7 times, most recently
from
5a5dcd3 to
132a2dc
Compare
tobiasgiese
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
tobiasgiese
force-pushed
the
tobiasgiese/bastion-recreation
branch
4 times, most recently
from
30b9f71 to
c82503e
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
The hash package computes the hash of a InstanceSpec using the spew library. Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
tobiasgiese
force-pushed
the
tobiasgiese/bastion-recreation
branch
from
c82503e to
9c9365e
Compare
k8s-ci-robot
removed
the
lgtm
|
had to rebase @seanschneeweiss / @jichenjc |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tobias Giese tobias.giese@mercedes-benz.com
Thanks to @chrischdi for the discussion and hash annotation idea! 🙂
TODO:
e2e test?(we will add envtests after Envtest mocks #1236 is merged)What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1298
Special notes for your reviewer:
TODOs:
/hold
Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum