🐛 Fix go1.19 linting errors

[tobiasgiese]

What this PR does / why we need it:

Currently we're facing the following issue:

test/e2e/shared/suite.go:27:2: SA1019: package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
	"io/ioutil"

xref

See go-critic/go-critic#1019

Further we have to make our linter happy, because the most recent test-infra image gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220726-61b7bafca6-master is using go1.19-rc2 (see kubernetes/test-infra#26920)

❯ docker run -ti --entrypoint bash gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220726-61b7bafca6-master
[...]
root@a4f4d8285e82:/workspace# go version
go version go1.19rc2 linux/amd64

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

_{Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum}

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	5edcac1
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62e107a5729d300008162e5b
😎 Deploy Preview	https://deploy-preview-1313--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[apricote]

/lgtm

Thanks for taking care of all these little things the last weeks @tobiasgiese !

[apricote]

/lgtm

[tobiasgiese]

/hold

We should discuss if want to fix these errors because of golangci-lint@v1.46.2 or if we want to downgrade to v1.44.0 (or similar).
See kubernetes-sigs/cluster-api#6737 (thx @chrischdi)

[seanschneeweiss]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanschneeweiss, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [seanschneeweiss,tobiasgiese]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seanschneeweiss]

👍 for fixing these errors.

Should we update golangci-lint to v1.47.2 in a following PR?

[tobiasgiese]

Should we update golangci-lint to v1.47.2 in a following PR?

I'd suggest to not update golangci-lint to v1.47.2, see kubernetes-sigs/cluster-api#6737 (comment)

v1.47.1 does not work due to performance issues in the revive linter. v1.47.2 disables the problematic linters allowing that version of golangci-lint to be used on CAPI at the cost of some linter coverage.

[tobiasgiese]

But I think it's fair to fix these errors (i.e., merge this PR).
k/k is doing this as well (kubernetes/kubernetes#111254)

[tobiasgiese]

/hold cancel