Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update devstack release #1329

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Aug 29, 2022

What this PR does / why we need it:

upgrade devstack to Yoga

NOTE:
I suspect this commit change the neutron plugin behavior of devstack so the service plugin trunk is not enabled by default (which leaves e2e fail) ,so I updated the conf file directly to include trunk plugin

commit f758b60a4b70261393242b932063d2b6d705594c
Author: Slawek Kaplonski <skaplons@redhat.com>
Date:   Wed Oct 6 12:02:22 2021 +0200

    Rehome functions to enable Neutron's Trunk service plugin

    Those functions were part of the neutron devstack plugin but we
    discussed on the neutron team meeting [1] to move it to the Devstack
    repo as it's mature enough now.

    [1] https://meetings.opendev.org/meetings/networking/2021/networking.2021-10-05-14.00.log.html#l-156

    Change-Id: I35446adad1d8a7fed142d834de20c48b611015a5

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2022
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 4c83cca
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/630d66ed6ce40c0008830959
😎 Deploy Preview https://deploy-preview-1329--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@jichenjc
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc jichenjc changed the title WIP: update devstack release update devstack release Aug 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2022
@tobiasgiese
Copy link
Member

/lgtm
👍🏻

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@jichenjc
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0725d2d into kubernetes-sigs:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants