🐛 Don't require an InstanceSpec for DeleteInstance #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
E2E test blocked by #1351 |
DeleteInstance requires very little data from InstanceSpec. The 2 methods to create an InstanceSpec, bastionToInstanceSpec and machineToInstanceSpec, require more state than is required by DeleteInstance, and have failure modes which are not relevant to DeleteInstance.
mdbooth
force-pushed
the
missing-sg-on-delete
branch
from
2889647 to
0f6b333
Compare
|
Rebased on top of the CI fix. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeleteInstance requires very little data from InstanceSpec. The 2 methods to create an InstanceSpec, bastionToInstanceSpec and machineToInstanceSpec, require more state than is required by DeleteInstance, and have failure modes which are not relevant to DeleteInstance.
Fixes #1264
/hold