Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accesIPv4 checking #1366

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix accesIPv4 checking #1366

merged 1 commit into from
Oct 28, 2022

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Oct 26, 2022 •
edited
Loading

What this PR does / why we need it:
Seems like the code got moved around, while checking for a condition
haven't, this commit makes sure we error out when instance we're
creating has no AccessIPv4 address candidate.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot requested a review from jichenjc October 26, 2022 16:04
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dulek!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dulek. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 26, 2022
@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 0d28348
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/635a5a8d9049d70008b5d2a4
😎 Deploy Preview https://deploy-preview-1366--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tobiasgiese
Copy link
Member

I don't think that we should remove it!
The validation was moved to the top of this func with #1094. We should rather fix it instead of removing it. WDYT @jichenjc?

@dulek
Copy link
Contributor Author

dulek commented Oct 26, 2022

I don't think that we should remove it! The validation was moved to the top of this func with #1094. We should rather fix it instead of removing it. WDYT @jichenjc?

Ah, true, the condition probably still makes sense, it just needs to go before getOrCreateRootVolume() invocation, right?

@mdbooth
Copy link
Contributor

mdbooth commented Oct 27, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 27, 2022
@tobiasgiese
Copy link
Member

/ok-to-test

We don't need the /ok-to-test as the removal is not reasonable

@mdbooth
Copy link
Contributor

mdbooth commented Oct 27, 2022

@tobiasgiese Ah, true! I added it on the basis that I trust @dulek before reading the issue.

@dulek You need to join the SIG! Then your oversights can warm the planet without delay like the rest of us 😉

@dulek
Fix accesIPv4 checking
0d28348 
Seems like the code got moved around, while checking for a condition
haven't, this commit makes sure we error out when instance we're
creating has no AccessIPv4 address candidate.
@dulek dulek force-pushed the nit-remove-condition branch from 8128274 to 0d28348 Compare October 27, 2022 10:16
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 27, 2022
@dulek dulek changed the title Remove nonsense condition Fix accesIPv4 checking Oct 27, 2022
@dulek
Copy link
Contributor Author

dulek commented Oct 27, 2022

Alright, I updated this by moving the if clause to what I think is a proper place. Please tell me if this makes sense.

@tobiasgiese
Copy link
Member

Fair for me 👍🏻

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2022
@jichenjc
Copy link
Contributor

@dulek is the commit message still valid? others lgtm

@dulek
Copy link
Contributor Author

dulek commented Oct 27, 2022

@dulek is the commit message still valid? others lgtm

Yes, I updated it. If it's not clear I can reword it.

@jichenjc
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit e70ae1a into kubernetes-sigs:main Oct 28, 2022
@dulek dulek mentioned this pull request Jan 9, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dulek @k8s-ci-robot @tobiasgiese @mdbooth @jichenjc