-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Synchronize versions between Makefile, Containerfile, e2e and go.mod #1369
🌱 Synchronize versions between Makefile, Containerfile, e2e and go.mod #1369
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @lentzi90. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Ah the cert-manager version should be synced the other way... There is no v1.8.3 tag, only v1.8.2. Fixing... |
0d3886c
to
3174b8b
Compare
/hold cancel |
/lgtm |
/assign @detiber |
@lentzi90 Jason is no active contributor of this project 🙂 even if Prow is mentioning him. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tobiasgiese The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unassign @detiber |
What this PR does / why we need it:
I noticed a warning in the e2e tests when trying to load the cert-manager images. It is because we have different versions in the e2e_conf.yaml and the Makefile.
I also bumped to go version in go.mod since we have 1.18 already in the Containerfile, and bumped the kubernetes version for the envtest. (It would be nice to automatically get the same version that we use for the e2e tests if someone can come up with a solution for that.)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): -Special notes for your reviewer:
TODOs:
/hold