🐛 Allow UDP traffic over nodeports

[huxcrux]

What this PR does / why we need it:
This PR adds a security group rule to allow UDP over nodeports.

Currently CAPO only allows TCP traffic to pass.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1395

Special notes for your reviewer:
N/A

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	9ae3231
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/637f58a3c129a20008a19f52
😎 Deploy Preview	https://deploy-preview-1396--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[k8s-ci-robot]

Welcome @bl0m1!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bl0m1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mnaser]

/lgtm

[k8s-ci-robot]

@mnaser: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[seanschneeweiss]

/ok-to-test

[huxcrux]

/retest

[jichenjc]

/test pull-cluster-api-provider-openstack-e2e-test

[jichenjc]

looks like the CI error is not related,

the change looks good
/lgtm

[mnaser]

/retest

[jichenjc]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl0m1, jichenjc, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

/cherry-pick v0.6

[k8s-infra-cherrypick-robot]

@jichenjc: once the present PR merges, I will cherry-pick it on top of v0.6 in a new PR and assign it to you.

In response to this:

/cherry-pick v0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

/hold cancel

[k8s-infra-cherrypick-robot]

@jichenjc: cannot checkout v0.6: error checking out v0.6: exit status 1. output: error: pathspec 'v0.6' did not match any file(s) known to git

In response to this:

/cherry-pick v0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jichenjc]

/cherry-pick release-0.6

[k8s-infra-cherrypick-robot]

@jichenjc: #1396 failed to apply on top of branch "release-0.6":

Applying: Allow UDP traffic to nodeports
Using index info to reconstruct a base tree...
A	pkg/cloud/services/networking/securitygroups_rules.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/cloud/services/networking/securitygroups_rules.go deleted in HEAD and modified in Allow UDP traffic to nodeports. Version Allow UDP traffic to nodeports of pkg/cloud/services/networking/securitygroups_rules.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow UDP traffic to nodeports
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.