Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱Ensure we capture early devstack logs #1399

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Nov 25, 2022

What this PR does / why we need it:
Hoping this might help us debug #1397 and similar future issues.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 975a1e2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6380af28f2e7090008a1ba59
😎 Deploy Preview https://deploy-preview-1399--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2022
@seanschneeweiss
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, seanschneeweiss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mdbooth,seanschneeweiss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 25, 2022

I understand @ralonsoh has enough to debug (thanks @stephenfin!) so I don't feel the need to push this while CI is failing. From the looks of the output it's working as intended, though.

@ralonsoh
Copy link

I understand @ralonsoh has enough to debug (thanks @stephenfin!) so I don't feel the need to push this while CI is failing. From the looks of the output it's working as intended, though.

Hi @mdbooth, please check #1397 (comment)

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 25, 2022

/retest

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 25, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a7f364 into kubernetes-sigs:main Nov 25, 2022
@stephenfin stephenfin deleted the devstack branch November 25, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants