Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Don't enable router-ovn service in CI deployments #1400

Merged
merged 1 commit into from
Nov 25, 2022
Merged

🐛 Don't enable router-ovn service in CI deployments #1400

merged 1 commit into from
Nov 25, 2022

Conversation

stephenfin
Copy link
Contributor

@stephenfin stephenfin commented Nov 25, 2022 •
edited
Loading

What this PR does / why we need it:

We are currently using the ML2-OVS neutron, not ML2-OVN. It doesn't make sense to enable the router-ovn service and should actually result in an error [1]. Don't do it.

[1] https://bugs.launchpad.net/neutron/+bug/1997970

Which issue(s) this PR fixes

Fixes #1397

Special notes for your reviewer:

None.

TODOs:

N/A.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2022
@netlify
Copy link

netlify bot commented Nov 25, 2022 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit e13cf66
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6380c1653b4f74000ab1dcfb
😎 Deploy Preview https://deploy-preview-1400--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 25, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @stephenfin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Nov 25, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 25, 2022
@mdbooth mdbooth self-assigned this Nov 25, 2022
@stephenfin
ci: Don't enable router-ovn
e13cf66 
We are currently using the ML2-OVS neutron, not ML2-OVN. It doesn't make
sense to enable the router-ovn service and should actually result in an
error [1]. Don't do it.

[1] https://bugs.launchpad.net/neutron/+bug/1997970

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 25, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Nov 25, 2022

/approve

Happy for this to merge as soon as it passes CI.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Nov 25, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Nov 25, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 27b46fb into kubernetes-sigs:main Nov 25, 2022
@mdbooth mdbooth deleted the issues/1397 branch November 25, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mdbooth mdbooth

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gate (temp?) failure due to devstack
3 participants
@stephenfin @k8s-ci-robot @mdbooth