⚠️ Add v1alpha7 #1497

mdbooth · 2023-02-28T14:18:42Z

Add a new v1alpha7 API version in anticipation of breaking API changes.

/hold

netlify · 2023-02-28T14:18:46Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`346b625`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6401e42741975300081805c8
😎 Deploy Preview	https://deploy-preview-1497--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

k8s-ci-robot · 2023-02-28T14:18:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mdbooth · 2023-02-28T14:54:50Z

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth · 2023-03-01T14:27:43Z

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90

Looks good!
One nit below, and one question: Should we change the clusterctl upgrade test to initialize with v1alpha6 instead of v1alpha5 now?
Ref:

cluster-api-provider-openstack/test/e2e/suites/e2e/clusterctl_upgrade_test.go

Line 52 in 1e18474

WorkloadFlavor: shared.FlavorV1alpha5,

lentzi90 · 2023-03-02T07:17:07Z

api/v1alpha6/conversion.go

@@ -1,5 +1,5 @@
 /*
-Copyright 2022 The Kubernetes Authors.
+Copyright 2021 The Kubernetes Authors.


Not sure where this came from. Maybe change it to 2023 instead?

That will be after I deleted it and then copied it from elsewhere after realising that was a mistake 😂

mdbooth · 2023-03-02T09:58:39Z

Looks good! One nit below, and one question: Should we change the clusterctl upgrade test to initialize with v1alpha6 instead of v1alpha5 now? Ref:

cluster-api-provider-openstack/test/e2e/suites/e2e/clusterctl_upgrade_test.go

Line 52 in 1e18474

WorkloadFlavor: shared.FlavorV1alpha5,

I would defer this to you. We could:

Leave it alone (test v1alpha5->v1alpha7)
Update it to v1alpha6 (test v1alpha6->v1alpha7)
Add a second test and do both

lentzi90 · 2023-03-02T10:13:10Z

I would defer this to you. We could:

* Leave it alone (test v1alpha5->v1alpha7)

* Update it to v1alpha6 (test v1alpha6->v1alpha7)

* Add a second test and do both

Probably the nicest thing would be to add a second test and test both. But I would say it is more important to have v1alpha6 -> v1alpha7.

mdbooth · 2023-03-02T16:45:04Z

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90

/lgtm

lentzi90 · 2023-03-03T06:27:06Z

Ah missed that the e2e-full test was failing...
It is because the e2e config is missing the v0.7.1 release that it is trying to use now. Basically the v0.6.4 section can be replaced with v0.7.1 here
https://github.com/shiftstack/cluster-api-provider-openstack/blob/28533e5a2b06d703781678f606507f3f64c66bf7/test/e2e/data/e2e_conf.yaml#L77-L91

mdbooth · 2023-03-03T09:29:07Z

/test pull-cluster-api-provider-openstack-e2e-full-test

mdbooth · 2023-03-03T09:29:41Z

Ah missed that the e2e-full test was failing... It is because the e2e config is missing the v0.7.1 release that it is trying to use now. Basically the v0.6.4 section can be replaced with v0.7.1 here https://github.com/shiftstack/cluster-api-provider-openstack/blob/28533e5a2b06d703781678f606507f3f64c66bf7/test/e2e/data/e2e_conf.yaml#L77-L91

Thanks! I've added a second section. Is that going to work?

lentzi90 · 2023-03-03T09:35:31Z

Having both v0.6.4 and v0.7.1 is perfectly fine, but now I see two sections with v0.7.99. Not sure how that will go 🤔

mdbooth · 2023-03-03T09:55:44Z

Having both v0.6.4 and v0.7.1 is perfectly fine, but now I see two sections with v0.7.99. Not sure how that will go 🤔

🤦

mdbooth · 2023-03-03T09:56:20Z

/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90

/lgtm

furkatgofurov7

This looks good to me, only one nit I could notice is missing the API types update in the doc: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/main/docs/book/src/clusteropenstack/configuration.md

mdbooth · 2023-03-03T11:06:10Z

I'll let this -full test complete before pushing a docs update. Assuming everything is ok I won't bother running it again.

furkatgofurov7 · 2023-03-03T11:35:25Z

I'll let this -full test complete before pushing a docs update. Assuming everything is ok I won't bother running it again.

@mdbooth makes sense 🙂
Although I see pull-cluster-api-provider-openstack-e2e-test is run in every and each PR which does not really makes sense to me (i.e for only doc update changes in #1500).
We could add run_If_changed on at least ^ e2e presubmit job (example: https://github.com/kubernetes/test-infra/blob/464e4bbc73d0934491fb285eca8719e22a173adc/config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml#L125) to ensure it is not run if only e.g. documentation is changed.

mdbooth · 2023-03-03T12:13:03Z

Only change is updating the api version refs in the docs.

lentzi90

Thanks!
/lgtm

furkatgofurov7

/lgtm

Not sure if the repo has requirements for the PR labels, but this is generally should be labelled as ⚠️ change to me.

mdbooth · 2023-03-03T14:59:43Z

/hold cancel

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023

k8s-ci-robot requested review from jichenjc and lentzi90 February 28, 2023 14:18

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 28, 2023

mdbooth force-pushed the v1alpha7 branch from 726568b to fe088af Compare February 28, 2023 14:36

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023

mdbooth force-pushed the v1alpha7 branch from fe088af to b496f62 Compare March 1, 2023 13:22

lentzi90 reviewed Mar 2, 2023

View reviewed changes

mdbooth force-pushed the v1alpha7 branch from b496f62 to 67428d5 Compare March 2, 2023 09:59

lentzi90 reviewed Mar 3, 2023

View reviewed changes

k8s-ci-robot assigned lentzi90 Mar 3, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023

mdbooth force-pushed the v1alpha7 branch from 28533e5 to 24ed004 Compare March 3, 2023 09:28

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023

mdbooth force-pushed the v1alpha7 branch from 24ed004 to 1477915 Compare March 3, 2023 09:55

lentzi90 reviewed Mar 3, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023

furkatgofurov7 reviewed Mar 3, 2023

View reviewed changes

mdbooth added 2 commits March 3, 2023 12:12

Add v1alpha7

7fdb189

Add v1alpha6 clusterctl upgrade test

346b625

mdbooth force-pushed the v1alpha7 branch from 1477915 to 346b625 Compare March 3, 2023 12:12

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023

lentzi90 reviewed Mar 3, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2023

furkatgofurov7 reviewed Mar 3, 2023

View reviewed changes

k8s-ci-robot assigned furkatgofurov7 Mar 3, 2023

mdbooth changed the title ~~✨ Add v1alpha7~~ ⚠️ Add v1alpha7 Mar 3, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2023

k8s-ci-robot merged commit c06146b into kubernetes-sigs:main Mar 3, 2023

mdbooth deleted the v1alpha7 branch March 3, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ Add v1alpha7 #1497

⚠️ Add v1alpha7 #1497

mdbooth commented Feb 28, 2023 •

edited

Loading

netlify bot commented Feb 28, 2023 •

edited

Loading

k8s-ci-robot commented Feb 28, 2023

mdbooth commented Feb 28, 2023

mdbooth commented Mar 1, 2023

lentzi90 left a comment

lentzi90 Mar 2, 2023

mdbooth Mar 2, 2023

mdbooth commented Mar 2, 2023

lentzi90 commented Mar 2, 2023

mdbooth commented Mar 2, 2023

lentzi90 left a comment

lentzi90 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 left a comment

furkatgofurov7 left a comment

mdbooth commented Mar 3, 2023

furkatgofurov7 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 left a comment

furkatgofurov7 left a comment

mdbooth commented Mar 3, 2023

⚠️ Add v1alpha7 #1497

⚠️ Add v1alpha7 #1497

Conversation

mdbooth commented Feb 28, 2023 • edited Loading

netlify bot commented Feb 28, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

k8s-ci-robot commented Feb 28, 2023

mdbooth commented Feb 28, 2023

mdbooth commented Mar 1, 2023

lentzi90 left a comment

Choose a reason for hiding this comment

lentzi90 Mar 2, 2023

Choose a reason for hiding this comment

mdbooth Mar 2, 2023

Choose a reason for hiding this comment

mdbooth commented Mar 2, 2023

lentzi90 commented Mar 2, 2023

mdbooth commented Mar 2, 2023

lentzi90 left a comment

Choose a reason for hiding this comment

lentzi90 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 left a comment

Choose a reason for hiding this comment

furkatgofurov7 left a comment

Choose a reason for hiding this comment

mdbooth commented Mar 3, 2023

furkatgofurov7 commented Mar 3, 2023

mdbooth commented Mar 3, 2023

lentzi90 left a comment

Choose a reason for hiding this comment

furkatgofurov7 left a comment

Choose a reason for hiding this comment

mdbooth commented Mar 3, 2023

mdbooth commented Feb 28, 2023 •

edited

Loading

netlify bot commented Feb 28, 2023 •

edited

Loading