-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 ci: bump flatcar to latest stable #1607
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/retest |
94972b9
to
6adf035
Compare
@@ -138,7 +138,7 @@ | |||
# https://docs.openstack.org/glance/latest/admin/quotas.html | |||
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/cirros/2022-12-05/cirros-0.6.1-x86_64-disk.img | |||
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/ubuntu/2023-01-14/focal-server-cloudimg-amd64.img | |||
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3510.2.3-kube-v1.27.2.img | |||
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/tormath1-flatcar/flatcar-stable-3510.2.4-kube-v1.27.2.img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't seem like an official image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it's not "official", it's for testing purposes - usually a CAPO maintainer upload this image to the CAPO bucket. (example: #1571 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you want to keep it as test image and update it after CI pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is correct. Once the CI will be green, I'll ask a CAPO maintainer to upload the image on the bucket (while #1502 is not done)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tormath1 Image is copied to the CAPO repo at https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3510.2.3-kube-v1.27.2.img
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdbooth thanks a lot! Any chance to change the version to "3510.2.4" ?
EDIT: I see the 3510.2.4 is uploaded 👌
/retest |
I'm reproducing the failing test to see what's going on. EDIT: I can't reproduce locally. The test is passing on my setup 🤔 EDIT: My bad, I forgot to bump the Flatcar version in the e2e conf 🤦 |
/retest |
6adf035
to
40b0cd0
Compare
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
40b0cd0
to
53df28b
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth, tormath1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Hey, there is new Flatcar stable release (flatcar/Flatcar#1106) - it mainly brings Kernel security fixes. Bumped the Kubernetes version to 1.27.3 too.
NOTE: Here's a small documentation for Flatcar / CAPO maintainers if someone wants to do it next time: https://gist.github.com/tormath1/acbae5c6cd12420bb8ea137e25655c99
Special notes for your reviewer:
TODOs:
/hold