Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ci: bump flatcar to latest stable #1607

Merged
merged 1 commit into from
Jul 19, 2023
Merged

🌱 ci: bump flatcar to latest stable #1607

merged 1 commit into from
Jul 19, 2023

Conversation

tormath1
Copy link
Contributor

Hey, there is new Flatcar stable release (flatcar/Flatcar#1106) - it mainly brings Kernel security fixes. Bumped the Kubernetes version to 1.27.3 too.

NOTE: Here's a small documentation for Flatcar / CAPO maintainers if someone wants to do it next time: https://gist.github.com/tormath1/acbae5c6cd12420bb8ea137e25655c99

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2023
@netlify
Copy link

netlify bot commented Jul 11, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 53df28b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64b661995f3b0a000806140f
😎 Deploy Preview https://deploy-preview-1607--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2023
@tormath1 tormath1 mentioned this pull request Jul 11, 2023
Closed
28 tasks
@tormath1
Copy link
Contributor Author

/retest

dulek
dulek suggested changes Jul 11, 2023
View reviewed changes
hack/ci/cloud-init/controller.yaml.tpl Outdated
@@ -138,7 +138,7 @@
# https://docs.openstack.org/glance/latest/admin/quotas.html
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/cirros/2022-12-05/cirros-0.6.1-x86_64-disk.img
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/ubuntu/2023-01-14/focal-server-cloudimg-amd64.img
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3510.2.3-kube-v1.27.2.img
/opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/tormath1-flatcar/flatcar-stable-3510.2.4-kube-v1.27.2.img
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem like an official image?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's not "official", it's for testing purposes - usually a CAPO maintainer upload this image to the CAPO bucket. (example: #1571 (comment))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so you want to keep it as test image and update it after CI pass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct. Once the CI will be green, I'll ask a CAPO maintainer to upload the image on the bucket (while #1502 is not done)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbooth @lentzi90 if you are around could you upload the image on the CAPO GCS bucket? 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tormath1 Image is copied to the CAPO repo at https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3510.2.3-kube-v1.27.2.img

Copy link
Contributor Author

@tormath1 tormath1 Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbooth thanks a lot! Any chance to change the version to "3510.2.4" ?

EDIT: I see the 3510.2.4 is uploaded 👌

@tormath1 tormath1 changed the title 🌱 ci: bump flatcar to latest stable and kubernetes 🌱 ci: bump flatcar to latest stable Jul 11, 2023
@jichenjc
Copy link
Contributor

/retest

@tormath1
Copy link
Contributor Author

tormath1 commented Jul 12, 2023 •
edited
Loading

I'm reproducing the failing test to see what's going on.

EDIT: I can't reproduce locally. The test is passing on my setup 🤔

EDIT: My bad, I forgot to bump the Flatcar version in the e2e conf 🤦

@tormath1
Copy link
Contributor Author

/retest

@tormath1
ci: bump flatcar to latest stable
53df28b 
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@tormath1
Copy link
Contributor Author

/retest

@mdbooth
Copy link
Contributor

mdbooth commented Jul 18, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tormath1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2023
@jichenjc
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2856f63 into kubernetes-sigs:main Jul 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth left review comments

@dulek dulek dulek requested changes

@jichenjc jichenjc Awaiting requested review from jichenjc

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tormath1 @jichenjc @mdbooth @k8s-ci-robot @dulek