-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 e2e: bastion tests #1822
🐛 e2e: bastion tests #1822
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @lentzi90 |
/test pull-cluster-api-provider-openstack-e2e-full-test |
I was thinking of an entirely separate and more complete Bastion test. It would, e.g.:
It could run against a cluster with a single control plane node and no workers. |
/hold |
/test pull-cluster-api-provider-openstack-e2e-test |
00efecd
to
20351c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE! Some suggestions inline. From experience, adding the failure descriptions is important in practise, so I'd be grateful if you could add those.
I wondered if this should be its own top-level test, but given the issues we've been having with CI capacity I think adding it to an existing test is pragmatic.
One more thing: I think we also support modification of a bastion instance in-place. I believe we store a hash of the spec, and if it changes we delete and recreate the bastion automatically with the new spec. Assuming my memory is serving me well it would be good to have a test for that, too, but I'd be happy to have it either in this or a separate PR.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
No, unfortunately this doesn't work this way (yet): #1866 |
@EmilienM: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
What this PR does / why we need it:
Deploying a bastion consumes resources so we now do it in its own test.
From now, the rest of the tests won't have a bastion node.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1821