-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds MaxIPs to OpenstackFloatingIPPool #1862
✨ Adds MaxIPs to OpenstackFloatingIPPool #1862
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @bilbobrovall. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e47c698
to
d7903b7
Compare
/ok-to-test |
/lgtm |
d7903b7
to
42c0ef9
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bilbobrovall, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Adds MaxIPs to OpenstackFloatingIPPool, after the pool has claimed that amount it will no longer create new floating IPs.
Relates to #1750 and solves a use case we have where we're preallocating entire ipranges, and we don't want random IPs if the pool is depleted. Our usecase could probably be solved by using cluster-api-ipam-provider-in-cluster for those clusters but we probably want to be able to control how many IPs a pool allocates anyways.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):relates to #1750
/hold