✨ Move spec.allowAllInClusterTraffic to spec.ManagedSecurityGroups
#1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilienM
changed the title
EmilienM
changed the title
spec.allowAllInClusterTraffic to spec.ManagedSecurityGroups`
EmilienM
changed the title
spec.allowAllInClusterTraffic to spec.ManagedSecurityGroups`spec.allowAllInClusterTraffic to spec.ManagedSecurityGroups
|
We need #1826 to merge first. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
mdbooth
reviewed
Feb 21, 2024
k8s-ci-robot
removed
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
mdbooth
approved these changes
Feb 22, 2024
| @@ -168,7 +168,7 @@ func (s *Service) generateDesiredSecGroups(openStackCluster *infrav1.OpenStackCl | |||
| controlPlaneRules = append(controlPlaneRules, getSGControlPlaneAdditionalPorts(openStackCluster.Spec.APIServerLoadBalancer.AdditionalPorts)...) | |||
| } | |||
|
|
|||
| if openStackCluster.Spec.AllowAllInClusterTraffic { | |||
| if openStackCluster.Spec.ManagedSecurityGroups != nil && openStackCluster.Spec.ManagedSecurityGroups.AllowAllInClusterTraffic { | |||
There was a problem hiding this comment.
It seems odd that we'd be in this function if ManagedSecurityGroups was nil. Also we checked it explicitly at the top of the function.
Still, belt and braces is no bad thing when dereferencing a pointer.
There was a problem hiding this comment.
yeah I thought the same but i'm trying to avoid pointer errors later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move
OpenStackCluster.Spec.AllowAllInClusterTrafficunderOpenStackCluster.Spec.ManagedSecurityGroups.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1878
TODOs: