Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 e2e: stop testing upgrades from v1alpha5 (v0.6) #1893

Merged
merged 1 commit into from
Feb 20, 2024
Merged

🐛 e2e: stop testing upgrades from v1alpha5 (v0.6) #1893

merged 1 commit into from
Feb 20, 2024

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

Since we stopped serving v1alpha5 and has been marked as deprecated for a long time now, let's stop testing upgrades from that version.
Instead, the upgrades will be tested from v0.7 which is based on v1alpha6 up to the latest version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1885

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit c51197e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65d3cfb2a08b950009492fc7
😎 Deploy Preview https://deploy-preview-1893--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM EmilienM changed the title CI/e2e: stop testing upgrades from v1alpha5 (v0.6) 🐛 e2e: stop testing upgrades from v1alpha5 (v0.6) Feb 19, 2024
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2024
@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM
Copy link
Contributor Author

/cc mdbooth

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor

I would not say this fixes #1885. That was already fixed. We just stop testing the 0.6 -> main upgrade, which is fine.

@lentzi90
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-full-test

@lentzi90
Copy link
Contributor

Not sure what that test failure was about. Looks like a flake to me. It got a TLS error from the webhook when applying the cluster template 🤷

lentzi90
lentzi90 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I wonder if we could add a v0.9 upgrade test while at it? We should anyway have an upgrade test from the latest release.

lentzi90
lentzi90 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's merge this and I can add the 0.9 test separatey.
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lentzi90
Copy link
Contributor

For reference, I'm adding the 0.9 upgrade in #1894

@lentzi90
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit c6ab0a3 into kubernetes-sigs:main Feb 20, 2024
10 checks passed
@EmilienM EmilienM deleted the issue_1885 branch February 20, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@mdbooth mdbooth mdbooth approved these changes

@dulek dulek Awaiting requested review from dulek

Assignees

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPO Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop serving v1alpha5
4 participants
@EmilienM @lentzi90 @k8s-ci-robot @mdbooth