-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: bump Flatcar version #1936
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Test is failing because the qemu images looks corrupted 🤷 Trying to generate a new one |
/test pull-cluster-api-provider-openstack-e2e-test |
61a1e78
to
f55dc21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tormath1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/hold |
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This commit sets the provider ID in the flatcar templates. To avoid issues with potential mismatches between node names and openstack servers we can configure the kubelet to set the provider ID. Otherwise, the cloud controller will try to match nodes and servers based on just the name. The names can differ because of special characters, like dots. When this happens, the cloud controller will be unable to match them and thus believe that the node has no underlying server. Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
f55dc21
to
957c9fc
Compare
Force pushed to fix a typo: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/compare/f55dc21c9d7dff33d15f0ab79c083d3faa543474..957c9fc464331d19e6187233a68a6be2accf2a32 I'm wondering how the CI did pass 🤷 |
/unhold |
/lgtm |
What this PR does / why we need it: Bump the Flatcar major version used by the regular
flatcar
template tests.Special notes for your reviewer:
containerd
shipped as a systemd-sysext image/hold
Closes: #1564