Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ ImageFilter - add exclusive validation -> pointers #1939

Merged
merged 2 commits into from
Mar 15, 2024
Merged

⚠️ ImageFilter - add exclusive validation -> pointers #1939

merged 2 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. ImageFilter - add validations, switch to pointers 

    This commit changes `ID` and `Name` of `ImageFilter` to pointers which
should only affect go marshalling.

Other than that it adds CEL validation of the ImageFilter, so that Name
or Tags can only be set when ID is unset. Conversions are updated
accordingly to make sure we only set Name when ID is unset.

Moreover validation is added that ID has to be UUID. It's not enforced
in conversions, as non-UUID IDs would produce clusters or machines that
would not work properly.
    @dulek
    dulek committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a00fa80 View commit details
    Browse the repository at this point in the history

  2. Add ImageFilter API validations 

    This adds tests related to kubebuilder validations of ImageFilter.
    @dulek
    dulek committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    dc3959e View commit details
    Browse the repository at this point in the history