Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add .gitattributes to identify generated files to GitHub #1963

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Mar 20, 2024

Example: https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github

A primary is to stop labelling relatively small commits as XXL just because they update some doctext which is referenced in several places in the CRDs.

This does what I intend in git:

> git check-attr linguist-generated ./config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml ./config/crd/kustomization.yaml
./config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml: linguist-generated: true
./config/crd/kustomization.yaml: linguist-generated: unspecified

However, I'm far from convinced the github integration is working. I originally included it in #1962, but it still seemed to be mislabelled.

/hold

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 20, 2024
Copy link

netlify bot commented Mar 20, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 4cd4e9f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65fae485c7e051000762c7c6
😎 Deploy Preview https://deploy-preview-1963--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2024
@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 20, 2024

CAPI are using the same attribute: https://github.com/kubernetes-sigs/cluster-api/blob/main/.gitattributes

@huxcrux
Copy link
Contributor

huxcrux commented Mar 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2024
@dulek
Copy link
Contributor

dulek commented Mar 20, 2024

Nice!

@mdbooth
Copy link
Contributor Author

mdbooth commented Mar 20, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 66d93db into kubernetes-sigs:main Mar 20, 2024
9 checks passed
@mdbooth mdbooth deleted the gitattributes branch March 20, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants