⚠️ RouterFilter to RouterParam #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4 tasks
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
mdbooth
force-pushed
the
routerparam
branch
3 times, most recently
from
5acde93
to
ddc45c5
Compare
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
dulek
approved these changes
Mar 29, 2024
Comment on lines
+541
to
+548
|
|
||
| func Convert_v1alpha7_RouterFilter_To_v1beta1_RouterFilter(_ *RouterFilter, _ *infrav1.RouterFilter, _ apiconversion.Scope) error { | ||
| return errors.New("Convert_v1alpha7_RouterFilter_To_v1beta1_RouterFilter should not be called") | ||
| } | ||
|
|
||
| func Convert_v1beta1_RouterFilter_To_v1alpha7_RouterFilter(_ *infrav1.RouterFilter, _ *RouterFilter, _ apiconversion.Scope) error { | ||
| return errors.New("Convert_v1beta1_RouterFilter_To_v1alpha7_RouterFilter should not be called") | ||
| } |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1975
An earlier version of this PR broke router deletion. It seems we have no unit test coverage of router reconciliation, so this PR also adds a test suite which would have caught the bug.
TODO:
/hold