do not hard code the ubuntu distributor name #306
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hchenxa If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @hchenxa. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
cc @gyliu513 |
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
/lgtm |
| swapoff -a | ||
| # disable swap in fstab | ||
| sed -i.bak -r 's/(.+ swap .+)/#\1/' /etc/fstab | ||
| curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add - | ||
| touch /etc/apt/sources.list.d/kubernetes.list | ||
| sh -c 'echo "deb http://apt.kubernetes.io/ kubernetes-xenial main" > /etc/apt/sources.list.d/kubernetes.list' | ||
| sh -c 'echo "deb http://apt.kubernetes.io/ kubernetes-${DISTRIBUTOR} main" > /etc/apt/sources.list.d/kubernetes.list' |
There was a problem hiding this comment.
Ubuntu 18.04 lsb_release -cs returns bionic, but there is no kubernetes-bionic: https://packages.cloud.google.com/apt/dists
| @@ -20,7 +21,7 @@ apt-get update | |||
| apt-get install -y apt-transport-https prips | |||
| apt-key adv --keyserver hkp://keyserver.ubuntu.com --recv-keys F76221572C52609D | |||
| cat <<EOF > /etc/apt/sources.list.d/k8s.list | |||
| deb [arch=amd64] https://apt.dockerproject.org/repo ubuntu-xenial main | |||
| deb [arch=amd64] https://apt.dockerproject.org/repo ubuntu-${DISTRIBUTOR} main | |||
There was a problem hiding this comment.
Ubuntu 18.04 lsb_release -cs returns bionic, but there is no kubernetes-bionic: https://apt.dockerproject.org/repo/dists/
There was a problem hiding this comment.
you are right, for bionic I tested and it works with ubuntu-xenial
so seems this should not be a good PR now, thanks for bring this out @hidekazuna
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
|
@jichenjc I think that's also not our job anymore :). Should be done differently either way in CAPI as a whole. I think the kubeadm bootstrapper relies on images where dependencies are already installed before cloud-init starts |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
@hchenxa: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'll close this PR because it's outdated. We do not provide the user data anymore since v1beta2. |
What this PR does / why we need it:
the distributor name was hard code with
xenial, prefer to not to hard code the distributor code name and get the name with command.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: