Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ remove unused v1alpha2 package and update doc #517

Closed

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Mar 11, 2020

What this PR does / why we need it:

As we're not really (imho) supporting migrations from v1alpha2 to v1alpha3 and the v1alpha2 package was unused in our implementation I would suggest removing it. I'm happy when we have v1alpha3 finalized I don't think we have the bandwidth to support migrations explicitly right now

See also: #499

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 11, 2020
@sbueringer
Copy link
Member Author

/assign @hidekazuna
/assign @prankul88
/assign @jichenjc

@hidekazuna
Copy link
Contributor

@sbueringer I agree we remove v1alpha2, I am not sure Cluster API policy though.
This PR seems conflict with #516 which drops v1alpha2 partially.

@sbueringer
Copy link
Member Author

sbueringer commented Mar 12, 2020

@sbueringer I agree we remove v1alpha2, I am not sure Cluster API policy though.
This PR seems conflict with #516 which drops v1alpha2 partially.

Shouldn't conflict. The goal of the other one was mainly to fix the makefile so our images after merge on master are build again, because that's broken for a while now. It's just that the regeneration with the new makefile removed a lot of v1alpha2 occurences. Ups I pushed one commit to many in the other PR :/

Afaik there is no official policy. Or at least it doesn't make sense to keep orphaned packages when we're not using them

@sbueringer
Copy link
Member Author

I'll close this PR here and use just the other one to make it not even more complicated. Sorry :/

@sbueringer sbueringer closed this Mar 12, 2020
@sbueringer sbueringer deleted the pr-remove-v1alpha2 branch March 12, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants