getOrCreatePort: add support to configure port Profile

[EmilienM]

Configuring port profiles can be useful to enable an application
running on the specified host to pass and receive VIF port-specific
information to the plugin.

One of the use-cases here is when configuring ports in OVS Hardware
offload, where we need to use the profile:
{"capabilities": ["switchdev"]}

Thanks to this patch, we'll now able to do it when creating the
machines and their ports.

Fix #965

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @EmilienM. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tobiasgiese]

/ok-to-test

[tobiasgiese]

Could you please create an issue for this PR? :)

[EmilienM]

Could you please create an issue for this PR? :)

done!

[EmilienM]

I don't know why it says I didn't sign the CLA, because I did. Is there a way to retrigger this check?

[tobiasgiese]

/retest

@EmilienM seems there is an issue with the pull-cluster-api-provider-openstack-test. You should check the logs or run the tests locally

[tobiasgiese]

I don't know why it says I didn't sign the CLA, because I did. Is there a way to retrigger this check?

The test will succeed automatically after you have signed the CLA successfully. Unfortunately, I don‘t know what should have gone wrong

[EmilienM]

/hold

sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha4:-: name requested for invalid type: interface{}
sigs.k8s.io/cluster-api-provider-openstack/api/v1alpha4:-: invalid map value type: interface{}

[tobiasgiese]

You could try adding the Profile to the e2e tests (i.e., to the cluster-template.yaml)

[EmilienM]

You could try adding the Profile to the e2e tests (i.e., to the cluster-template.yaml)

cluster-template.yaml has not port creation, I'll see if we can add one, with a Profile. Maybe into another PR, if possible.

[tobiasgiese]

cluster-template.yaml has not port creation, I'll see if we can add one, with a Profile. Maybe into another PR, if possible.

Okay for me 👍🏻

/lgtm

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-test

[tobiasgiese]

I found the following in the capo-controller-manager Pod logs

(rule:create_port and rule:create_port:binding:profile) is disallowed by policy

E0811 15:28:07.856507       1 controller.go:304] controller-runtime/manager/controller/openstackcluster "msg"="Reconciler error" "error"="failed to reconcile bastion: Request forbidden: [POST http://10.0.2.15:9696/v2.0/ports], error message: {\"NeutronError\": {\"type\": \"PolicyNotAuthorized\", \"message\": \"(rule:create_port and rule:create_port:binding:profile) is disallowed by policy\", \"detail\": \"\"}}" "name"="cluster-e2e-a0kfgh" "namespace"="e2e-a0kfgh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="OpenStackCluster"

[EmilienM]

I found the following in the capo-controller-manager Pod logs

(rule:create_port and rule:create_port:binding:profile) is disallowed by policy

E0811 15:28:07.856507       1 controller.go:304] controller-runtime/manager/controller/openstackcluster "msg"="Reconciler error" "error"="failed to reconcile bastion: Request forbidden: [POST http://10.0.2.15:9696/v2.0/ports], error message: {\"NeutronError\": {\"type\": \"PolicyNotAuthorized\", \"message\": \"(rule:create_port and rule:create_port:binding:profile) is disallowed by policy\", \"detail\": \"\"}}" "name"="cluster-e2e-a0kfgh" "namespace"="e2e-a0kfgh" "reconciler group"="infrastructure.cluster.x-k8s.io" "reconciler kind"="OpenStackCluster"

nicely found. I suspect we'll have to set it to nil by default.

[EmilienM]

@tobiasgiese for review again. Thanks!

[tobiasgiese]

/lgtm
👍🏻

[tobiasgiese]

Can you PTAL @jichenjc :)
Unfortunately, I don't have the permission to approve

[jichenjc]

/approve
/hold cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment