Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Kubebuilder #66

Closed
frodenas opened this issue Oct 8, 2018 · 2 comments
Closed

Migrate to Kubebuilder #66

frodenas opened this issue Oct 8, 2018 · 2 comments
Assignees
@sflxn

Comments

@frodenas
Copy link

frodenas commented Oct 8, 2018

Cluster-API has migrated to kubebuilder and CRDs (PR kubernetes-sigs/cluster-api#494). We need to sync the vsphere cluster-api provider with the upstream changes.
@sflxn
Copy link

sflxn commented Oct 24, 2018

/assigned. In progress.

@sflxn sflxn mentioned this issue Oct 31, 2018
Merged
sflxn pushed a commit that referenced this issue Nov 9, 2018
Updated code, scripts, makefile for CRD migration
35ef79b 
Fixed the project post CRD migration.  The build now works.  There are
a few changes in this commit, listed below.

1. Removed all unused code, scripts, and files.  This includes the old
controller's Dockerfile and makefile.
2. The old controller's Dockerfile and makefile have been rolled up into
the top level.
3. Updated the container image name with our current registry store on GCR.
4. Made a number of changes to the CRD files under config/.
5. Modify how generate-yaml.sh works.  It now calls kustomize instead of
using sed.
6. Added a 'create-yaml' target in the makefile to generate the actual
set of yaml files for clusterctl.

Fixes #38 and #66
sflxn pushed a commit that referenced this issue Nov 9, 2018
Updated code, scripts, makefile for CRD migration
0f6df52 
Fixed the project post CRD migration.  The build now works.  There are
a few changes in this commit, listed below.

1. Removed all unused code, scripts, and files.  This includes the old
controller's Dockerfile and makefile.
2. The old controller's Dockerfile and makefile have been rolled up into
the top level.
3. Updated the container image name with our current registry store on GCR.
4. Made a number of changes to the CRD files under config/.
5. Modify how generate-yaml.sh works.  It now calls kustomize instead of
using sed.
6. Added a 'create-yaml' target in the makefile to generate the actual
set of yaml files for clusterctl.

Fixes #38 and #66
@sflxn sflxn self-assigned this Nov 20, 2018
k8s-ci-robot pushed a commit that referenced this issue Nov 21, 2018
@k8s-ci-robot
Migration of the vsphere provider to CRD (#105)
c4d3395 
* Migration to CRDs

This is a nearly buildable update of the vSphere provider to CRD.  The
next commit should be a clean dep ensure to populate the vendors.  Once
that is complete, this repo should be buildable.

The update was done using kubebuilder on a separate project and then
introducing those CRD updates to this repo.  The provider code was
updated to work with the new structure.  The kustomize and clusterctl
yaml config files still needs updating before this can be tested.

* Updated code, scripts, makefile for CRD migration

Fixed the project post CRD migration.  The build now works.  There are
a few changes in this commit, listed below.

1. Removed all unused code, scripts, and files.  This includes the old
controller's Dockerfile and makefile.
2. The old controller's Dockerfile and makefile have been rolled up into
the top level.
3. Updated the container image name with our current registry store on GCR.
4. Made a number of changes to the CRD files under config/.
5. Modify how generate-yaml.sh works.  It now calls kustomize instead of
using sed.
6. Added a 'create-yaml' target in the makefile to generate the actual
set of yaml files for clusterctl.

Fixes #38 and #66

* Dep ensure to get latest vendor code

* Fix makefile targets and CRD rbac files

1. Cleaned up makefile.  Added 3 images, production, dev, and ci.
2. Modified the CI push target to decode the service account info
from Travis CI.
3. Fix up the CRD rbac files that got lost in the squashes.
4. Updated the travis CI config

Resolves #79

* Fixed informers, comments, logs

Fixed informers starting up.  Removed commented out code and unused code.
Added more logging.

* Add scripts for testing in CI

Added some scripts from the cluster-api-provider-gcp project
that adds kubebuilder and other necessary components in CI for
testing.
@sflxn
Copy link

sflxn commented Feb 1, 2019

This was completed. #105

@sflxn sflxn closed this as completed Feb 1, 2019
jayunit100 pushed a commit to jayunit100/cluster-api-provider-vsphere that referenced this issue Feb 26, 2020
@detiber @k8s-ci-robot
Start docs around idempotent AWS resource management (kubernetes-sigs#66
3f7039c 
)

* Start docs around idempotent AWS resource management

* Additional context

* wip updates

* add misc todos

* tweaks

* add workflow for resources that do not support tags

* tweaks

* more tweaks

* tweak

* updates

* tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sflxn sflxn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frodenas @sflxn