Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Using ClusterCacheTracker instead of remote.NewClusterClient #2132

Merged
merged 1 commit into from
Aug 8, 2023
Merged

🌱 Using ClusterCacheTracker instead of remote.NewClusterClient #2132

merged 1 commit into from
Aug 8, 2023

Conversation

laozc
Copy link
Member

@laozc laozc commented Aug 1, 2023

What this PR does / why we need it:
Using ClusterCacheTracker instead of remote.NewClusterClient

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2053

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 1, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 1, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2023
@sbueringer
Copy link
Member

@laozc Q: No rush, just asking because of the draft status. Is this PR ready for review?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2023
@laozc laozc marked this pull request as ready for review August 2, 2023 10:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
@laozc
Copy link
Member Author

laozc commented Aug 2, 2023

@laozc Q: No rush, just asking because of the draft status. Is this PR ready for review?

/ok-to-test

I was waiting for the two related PRs to merge first. 😁
Ready for review now.

chrischdi
chrischdi reviewed Aug 3, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
controllers/controllers_suite_test.go Outdated Show resolved Hide resolved
controllers/vspherevm_controller_test.go Outdated Show resolved Hide resolved
@laozc laozc force-pushed the cluster-cache branch 2 times, most recently from 124988a to 5c3f87e Compare August 3, 2023 06:35
sbueringer
sbueringer reviewed Aug 3, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
controllers/controllers_suite_test.go Outdated Show resolved Hide resolved
controllers/controllers_suite_test.go Show resolved Hide resolved
controllers/serviceaccount_controller.go Show resolved Hide resolved
controllers/vspherevm_controller_test.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@chrischdi chrischdi mentioned this pull request Aug 3, 2023
Merged
@laozc laozc force-pushed the cluster-cache branch 6 times, most recently from 6e9b91e to 215e49e Compare August 4, 2023 04:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@sbueringer
Copy link
Member

sbueringer commented Aug 4, 2023 •
edited
Loading

@sbueringer : I guess we can add an additional PR if the flag name changes in core CAPI?

I posted your core CAPI PR in Slack. I'm planning to merge the core CAPI PR on Monday (please ping me if I forget it)

@laozc
Copy link
Member Author

laozc commented Aug 4, 2023

@sbueringer : I guess we can add an additional PR if the flag name changes in core CAPI?

I posted your core CAPI PR in Slack. I'm planning to merge the core CAPI PR on Monday (please ping me if I forget it)

Let me know if the flag name is changed to another one. 😊

@sbueringer
Copy link
Member

/lgtm

Yup will report back

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8005af50eeafd2d036745fee29534e93895070f

@sbueringer sbueringer added this to the v1.8 milestone Aug 4, 2023
@sbueringer
Copy link
Member

core CAPI is merged

/approve

Thank you!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2023
@laozc
Copy link
Member Author

laozc commented Aug 8, 2023

/retest-required

@sbueringer
Copy link
Member

/hold
Discussion ongoing in core CAPI about the name of the flag

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@sbueringer
Copy link
Member

@laozc can you drop the flag and just hard code cct concurrency to 10 for now?

This unblocks this pr for CAPV 1.8. And we can still consider adding the flag later. I'm pretty sure we don't actually need the flag as 10 should be easily enough for this reconciler

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@laozc
Copy link
Member Author

laozc commented Aug 8, 2023

@laozc can you drop the flag and just hard code cct concurrency to 10 for now?

This unblocks this pr for CAPV 1.8. And we can still consider adding the flag later. I'm pretty sure we don't actually need the flag as 10 should be easily enough for this reconciler

Sure. Reverted the new flag related change.
Will add it back if the new flag needed after 1.8.

@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

pending CI, but Prow will take care of it

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e42dc816e0381961dacd8ca62a29a60b8f3ed94d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 8, 2023 •
edited
Loading

@laozc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-vsphere-apidiff-main 071401f link false /test pull-cluster-api-provider-vsphere-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5ba5364 into kubernetes-sigs:main Aug 8, 2023
8 of 10 checks passed
@laozc laozc mentioned this pull request Aug 29, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srm09 srm09 srm09 left review comments

@yastij yastij Awaiting requested review from yastij

@zhanggbj zhanggbj Awaiting requested review from zhanggbj

@MaxRink MaxRink Awaiting requested review from MaxRink

@chrischdi chrischdi Awaiting requested review from chrischdi

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Consider using ClusterCacheTracker instead of remote.NewClusterClient
5 participants
@laozc @k8s-ci-robot @sbueringer @chrischdi @srm09