Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] 🌱 Set base branch correctly for link checker #3265

Merged
merged 1 commit into from
Nov 28, 2024
Merged

[release-1.12] 🌱 Set base branch correctly for link checker #3265

merged 1 commit into from
Nov 28, 2024

Conversation

fabriziopandini
Copy link
Member

Part of 1.12-rc.0 release tasks

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7cfec2732e582467b0b9edc4de601930bc617ca

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2024
@fabriziopandini
Copy link
Member Author

/retest

@fabriziopandini fabriziopandini force-pushed the release-1.12-link-check-base-branch branch from 5e08ddb to 03def63 Compare November 27, 2024 20:40
@fabriziopandini
Copy link
Member Author

/hold
it seems that the PR is not getting all the jobs 🤔
I will take a look tomorrow

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2024
@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-govmomi-release-1-12
  • /test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-release-1-12
  • /test pull-cluster-api-provider-vsphere-test-release-1-12
  • /test pull-cluster-api-provider-vsphere-verify-release-1-12

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-vsphere-apidiff-release-1-12

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-vsphere-verify-release-1-12

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

/hold it seems that the PR is not getting all the jobs 🤔 I will take a look tomorrow

Which jobs are you missing?

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-provider-vsphere-verify-release-1-12
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5427025 into kubernetes-sigs:release-1.12 Nov 28, 2024
13 checks passed
@fabriziopandini fabriziopandini deleted the release-1.12-link-check-base-branch branch December 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxRink MaxRink Awaiting requested review from MaxRink

@srm09 srm09 Awaiting requested review from srm09

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @chrischdi @k8s-ci-robot