Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kustomize to v5 #8457

Closed
killianmuldoon opened this issue Apr 3, 2023 · 9 comments
Closed

Bump Kustomize to v5 #8457

killianmuldoon opened this issue Apr 3, 2023 · 9 comments
Labels
area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@killianmuldoon
Copy link
Contributor

Kustomize released v5.0.0 in February - CAPI should bump the Kustomize version to keep up. Release notes are here.

The following need to be taken care of ahead of and / or alongside the Kustomize bump:

  1. Ensure encoding of creationTimestamp is handled correctly. This should be handled in upstream Kustomize - issue here - but if not there are workarounds for CAPI - e.g. patch creationTimestamp on each and every CRD. Reference issue in CAPI.
  2. Take care of deprecations: The following have been deprecated:
  • vars -> replacements
  • bases -> resources
  • patchesStrategicMerge -> patches
  • patchesJson6902 -> patches

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 3, 2023
@fabriziopandini
Copy link
Member

Let's consider if to wait for a patch release with the fix for creationTimestamp
/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Let's consider if to wait for a patch release with the fix for creationTimestamp
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2023
@killianmuldoon
Copy link
Contributor Author

Let's consider if to wait for a patch release with the fix for creationTimestamp

Yeah - I'm watching that issue to see if there's an update. We should consider it a blocker until then IMO.

@james-callahan
Copy link

Yeah - I'm watching that issue to see if there's an update. We should consider it a blocker until then IMO.

Should still be able to work through the deprecations in the mean-time.

@sbueringer
Copy link
Member

sbueringer commented Apr 22, 2023

I've opened a related issue to bump controller-tools: #8546

As far as I can tell we should be able to bump kustomize after we bumped controller-tools?

@fabriziopandini
Copy link
Member

/kind cleanup
/priority-important-soon

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 11, 2024
@fabriziopandini
Copy link
Member

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 11, 2024
@sbueringer
Copy link
Member

Done in #10294

/close

@killianmuldoon Maybe you can double check. But as far as I can telle verything is done (and we now use kustomize v5.3)

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Done in #10294

/close

@killianmuldoon Maybe you can double check. But as far as I can telle verything is done (and we now use kustomize v5.3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants