[Question] should we support adding roles to worker node ?

[jichenjc]

This actually comes from kubernetes-sigs/cluster-api-provider-openstack#298
but I think it's applicable to cluster-api

should we add this into yaml so that user is able to set role during cluster-api creation stage or guide user to change the role after cluster is up?

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

[gyliu513]

/cc @vincepri @detiber

Thanks @jichenjc , +1 for this.

[detiber]

In the AWS provider we started setting the worker node role to node. I do like the idea of being able to specify the role, though.

[vincepri]

Hopefully the role can be offered, in the fullness of time, as a top level configuration parameter and default to node as @detiber mentioned.

[jichenjc]

@detiber can you tell me where's the place to add role in aws provider? just want to refer to .. thanks

[jichenjc]

/assign

I can take a look and see how we can achieve this

[tahsinrahman]

@jichenjc

• aws: https://github.com/tahsinrahman/cluster-api-provider-aws/blob/50bda8c90faa57a53b4c535136f94e854ab9f5a3/pkg/cloud/aws/services/kubeadm/aws_defaults.go#L170
• azure: https://github.com/tahsinrahman/cluster-api-provider-azure/blob/3734f39b9d0d24eac62fc3a607a5c9fc7ccbaa4b/pkg/cloud/azure/services/config/node.go#L51

[jichenjc]

@tashimi thanks for the comments ~

[jichenjc]

#493 seems addressed this issue ...

[ncdc]

Closing this as a duplicate of #493.
/close

[k8s-ci-robot]

@ncdc: Closing this issue.

In response to this:

Closing this as a duplicate of #493.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.