Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Optimize dependabot config #10571

Merged
merged 1 commit into from
May 8, 2024
Merged

🌱 Optimize dependabot config #10571

merged 1 commit into from
May 8, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 7, 2024 •
edited
Loading

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR aims to reduce dependabot toil by:

Ideally we'll mostly get 2 PRs every week, one for actions one for go dependencies

I would like to experiment a bit with this config. If it works out well we can keep it (and also use it in other repos like e.g. CAPV)

Example PRs:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2024
@sbueringer sbueringer added the area/ci Issues or PRs related to ci label May 7, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 7, 2024
@sbueringer
Copy link
Member Author

/assign @killianmuldoon @chrischdi @fabriziopandini

@sbueringer sbueringer force-pushed the pr-optim-dependabot branch from 9b173c0 to cc5e568 Compare May 7, 2024 16:56
@sbueringer
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 7, 2024
killianmuldoon
killianmuldoon reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Seems like a really good change

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5710910792f60e43e93e9c119ce50f0fd4200ec0

@killianmuldoon
Copy link
Contributor

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 7, 2024
@killianmuldoon
Copy link
Contributor

Just in case you weren't ready to merge

@sbueringer
Copy link
Member Author

Just testing some random stuff for another PR

/test ?

@k8s-ci-robot

This comment was marked as resolved.

Sign in to view
@sbueringer
Copy link
Member Author

/test lint

@k8s-ci-robot

This comment was marked as resolved.

Sign in to view
chrischdi
chrischdi reviewed May 8, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member Author

Will update in a bit, found something good 😃

@sbueringer sbueringer mentioned this pull request May 8, 2024
Closed
@sbueringer sbueringer force-pushed the pr-optim-dependabot branch from cc5e568 to 14e6117 Compare May 8, 2024 08:23
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2024
@sbueringer
Copy link
Member Author

@chrischdi @killianmuldoon Updated PR description and content, PTAL :)

sbueringer
sbueringer commented May 8, 2024
View reviewed changes
.github/dependabot.yaml
schedule:
interval: "weekly"
day: "monday"
## group all dependencies with a k8s.io prefix into a single PR.
groups:
kubernetes:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch group will already contain Kubernetes (because for Kubernetes we ignore major + minor updates)

chrischdi
chrischdi reviewed May 8, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 40e4904b9613d49579d9b3e46d796ba847be5f9e

@sbueringer
Optimize dependabot config
cfc1349 
Signed-off-by: Stefan Büringer buringerst@vmware.com
killianmuldoon
killianmuldoon reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer sbueringer force-pushed the pr-optim-dependabot branch from 14e6117 to cfc1349 Compare May 8, 2024 08:55
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@sbueringer
Copy link
Member Author

sbueringer commented May 8, 2024 •
edited
Loading

Sorry one last change. I also added it to the PR description, but just to emphasize.

PRs on my fork with the current config on top of release-1.6:

Not sure if publicly available: dependabot log: https://github.com/sbueringer/cluster-api/network/updates/20333354/jobs

So overall three PRs to bump everything in release-1.6 to latest :)

(need a clean new run now)

EDIT Broke my fork in a strange way (too much playing around). Here is a clean CAPV example:

chrischdi
chrischdi reviewed May 8, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d885c3b63caeed45f54fe378432a303ce80a0f8

@sbueringer sbueringer mentioned this pull request May 8, 2024
Merged
@sbueringer
Copy link
Member Author

@killianmuldoon Feel free to merge directly once you took another look

@sbueringer
Copy link
Member Author

I'll go ahead to already use it. Let me know if there are any further findings and I'll follow-up

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5b4a342 into kubernetes-sigs:main May 8, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 8, 2024
@sbueringer sbueringer deleted the pr-optim-dependabot branch May 8, 2024 15:10
@mboersma mboersma mentioned this pull request May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @killianmuldoon @chrischdi @fabriziopandini