🌱 Handle finalizers early in Reconciles #11286
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/test pull-cluster-api-e2e-main /hold |
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-move-finalizer-logic
branch
from
b7ee8b6 to
1f9ec2e
Compare
|
/test pull-cluster-api-e2e-main |
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-move-finalizer-logic
branch
from
1f9ec2e to
7183826
Compare
|
Rebased /hold cancel |
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-e2e-main |
| return false, err | ||
| } | ||
|
|
||
| controllerutil.AddFinalizer(o, finalizer) |
There was a problem hiding this comment.
Nit, not for this PR.
I think we should stop calling the patch helper when it is easy to figure out that no changes have been applied, like in this case (this will avoid a few Mashal operations)
There was a problem hiding this comment.
Not sure I understand what you mean. In general I agree we shouldn't call the patch helper if we know that there is no change. But in this case there will always be a change?
(or do you mean just in general when using a func like AddFinalizer that easily tells us if there was a change?)
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 52881545fdbf66982ddd56af5d8b4abbae0beec3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11105