Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 [release-1.7] Bump github.com/coredns/corefile-migration to v1.0.24 #11532

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Kubernetes bumped to coredns v1.11.3 in v1.30.5.

xref:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area dependency

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 4, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2024
@chrischdi chrischdi force-pushed the pr-bump-corefile-migration-1-7 branch from 26f36ca to 1edab3f Compare December 4, 2024 08:49
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 4, 2024
@chrischdi chrischdi changed the title 🌱 Bump github.com/coredns/corefile-migration to v1.0.24 🌱 [release-1.7] Bump github.com/coredns/corefile-migration to v1.0.24 Dec 4, 2024
@chrischdi
Copy link
Member Author

/hold

In case there are opinions not to merge this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@fabriziopandini
Copy link
Member

fabriziopandini commented Dec 4, 2024

/lgtm
/approve

CAPI 1.7 support the 1.30 release, so it seems fair to make it possible to use the core DNS version tested with 1.30.5

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c1ceeef1ef61e5b4a50b75ab43a83eb8ef4a96c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2024
@fabriziopandini
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 94e7810 into kubernetes-sigs:release-1.7 Dec 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants