✨ Add PriorityQueue feature gate #11698
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
k8s-ci-robot
added
cncf-cla: yes
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
|
/test pull-cluster-api-e2e-main |
|
If anyone has an idea which existing or potentially new area label would fit, let me know |
|
/assign @fabriziopandini @chrischdi |
| @@ -401,6 +401,7 @@ variables: | |||
| CLUSTER_TOPOLOGY: "true" | |||
| EXP_RUNTIME_SDK: "true" | |||
| EXP_MACHINE_SET_PREFLIGHT_CHECKS: "true" | |||
| EXP_PRIORITY_QUEUE: "false" | |||
There was a problem hiding this comment.
Don't we want to enable it for testing?
Or at least in some test?
There was a problem hiding this comment.
Not sure how to enable this only for some tests.
I think we have to preserve our current test coverage for the feature gate being off as that is what (almost?) everyone will run in production.
I personally would mainly use this feature gate for now to enable the feature in scale tests (outside of CI)
There was a problem hiding this comment.
+1 to experiment outside CI first
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: daf98bd3e474ab1c5f0ec94e38bf0fba9433547f
|
|
MachinePool flake /test pull-cluster-api-e2e-main |
|
/cc @vincepri |
|
Thanks for this PR! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
I would like to propose a new feature gate for the new CR Priority Queue feature (kubernetes-sigs/controller-runtime#2374). Sooner or later this will probably be the only queue implementation in CR, the feature gate would allow us to get some experience and run scale tests with the new feature.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #