Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add spec doc for cluster infra provider #1791

Merged

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Nov 20, 2019

What this PR does / why we need it:
Add a specification document containing the required data model and
behaviors for cluster infrastructure providers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1724

@ncdc ncdc added kind/documentation Categorizes issue or PR as related to documentation. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 20, 2019
@ncdc ncdc added this to the v0.3.0 milestone Nov 20, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Nov 20, 2019

FYI @randomvariable - this is what I've started

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2019
Add a specification document containing the required data model and
behaviors for cluster infrastructure providers.

Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
@ncdc ncdc force-pushed the cluster-infra-provider-spec branch from c49f668 to 62092ef Compare December 2, 2019 16:56
@ncdc ncdc changed the title [WIP] 📖 Add spec doc for cluster infra provider 📖 Add spec doc for cluster infra provider Dec 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2019
@detiber
Copy link
Member

detiber commented Dec 2, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit b88a9ce into kubernetes-sigs:master Dec 2, 2019
@ncdc ncdc deleted the cluster-infra-provider-spec branch December 3, 2019 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add specification document for cluster infrastructure provider
3 participants