Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose spot instances support for roadmap #2532

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Propose spot instances support for roadmap #2532

merged 1 commit into from
Mar 4, 2020

Conversation

enxebre
Copy link
Member

@enxebre enxebre commented Mar 4, 2020

Propose AWS spot instances support #1876 for the roadmap

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
vincepri
vincepri reviewed Mar 4, 2020
View reviewed changes
docs/book/src/roadmap.md Outdated
@@ -22,6 +22,7 @@ This roadmap is a constant work in progress, subject to frequent revision. Dates
- [Extensible machine pre-delete hooks](https://github.com/kubernetes-sigs/cluster-api/issues/1514)
- Define clusterctl inventory specification & have providers implement it
- Figure out how to change configurations through rolling updates (e.g. apiserver flags, DNS/addons, etc.)
- [AWS Spot instances support](https://github.com/kubernetes-sigs/cluster-api/issues/1876)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [AWS Spot instances support](https://github.com/kubernetes-sigs/cluster-api/issues/1876)
- [Spot instances support](https://github.com/kubernetes-sigs/cluster-api/issues/1876)

This should probably be generic, wdyt?

@k8s-ci-robot
Copy link
Contributor

@enxebre: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-capd-e2e db914e2 link /test pull-cluster-api-capd-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

vincepri
vincepri approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/milestone v0.3.0-rc.3

@k8s-ci-robot k8s-ci-robot added this to the v0.3.0-rc.3 milestone Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit edc797c into kubernetes-sigs:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3.0-rc.3
Development

Successfully merging this pull request may close these issues.
3 participants
@enxebre @k8s-ci-robot @vincepri