-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add node-conditions to the MachineStatus #483
Add node-conditions to the MachineStatus #483
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits about the comments for the new field.
@@ -141,6 +141,14 @@ type MachineStatus struct { | |||
// Addresses is a list of addresses assigned to the machine. Queried from cloud provider, if available. | |||
// +optional | |||
Addresses []corev1.NodeAddress `json:"addresses,omitempty"` | |||
|
|||
// List of conditions synced from the node-conditions of the corresponding node-object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "node conditions" (with a space)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
||
// List of conditions synced from the node-conditions of the corresponding node-object. | ||
// Machine-controller would be responsible for keeping conditions up-to-date. | ||
// Machine-set controller will be taking these conditions as a signal to decide if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: MachineSet controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -141,6 +141,14 @@ type MachineStatus struct { | |||
// Addresses is a list of addresses assigned to the machine. Queried from cloud provider, if available. | |||
// +optional | |||
Addresses []corev1.NodeAddress `json:"addresses,omitempty"` | |||
|
|||
// List of conditions synced from the node-conditions of the corresponding node-object. | |||
// Machine-controller would be responsible for keeping conditions up-to-date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Machine controller is responsible ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
/hold Adding a hold since this is an API change to discuss during the weekly meeting. |
/lgtm. This can also be used to fix #253 |
/lgtm |
Leaving the hold for ~1 day as discussed during the WG call today. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardikdr, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It's been a day, removing the hold. /hold cancel |
What this PR does / why we need it: Based on the discussion in the last sig-call, adding node-conditions into Machine-status. Basically Machine-set controller will be able to understand the Machine-health from these conditions- few of them are
DiskPressure
,KubeleteReady
,MemoryPressure
and so on. Based on these conditions - Machineset can decide whether Machine . needs to be replaced/udpated - eg. DiskPressure from X minutes, KubeleteNotReady from Y minutes so on.Refer: https://kubernetes.io/docs/concepts/architecture/nodes/#condition
Which issue(s) this PR fixes :
This PR will partially resolve- #47, though we need to rediscuss the current approach where machineset is pulling the node-object to understand the machine-health.
Special notes for your reviewer: Executed
make generate
,make build
, to mention explicitlymake depend
is getting stuck[for long] at dep issues due to api-builder- so avoided that for now.Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: