Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 topologyReconcileLogger: print the correct log lines #5584

Merged
merged 1 commit into from
Nov 4, 2021
Merged

🌱 topologyReconcileLogger: print the correct log lines #5584

merged 1 commit into from
Nov 4, 2021

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #5568

/assign sbueringer

@sbueringer
topologyReconcileLogger: print the correct log lines
423e0dc 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.0 milestone Nov 4, 2021
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 4, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2021
@sbueringer
Copy link
Member

/retitle 🌱 topologyReconcileLogger: print the correct log lines

If there are any conventions about mentioning the branch we cherry-pick onto in the PR name, please let me know!
/lgtm

@k8s-ci-robot k8s-ci-robot changed the title [release-1.0] 🌱 topologyReconcileLogger: print the correct log lines 🌱 topologyReconcileLogger: print the correct log lines Nov 4, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2021
killianmuldoon
killianmuldoon approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit cd72243 into kubernetes-sigs:release-1.0 Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon