✨ CABPK: Add support for kubeadm skipPhases field

[dntosas]

What this PR does / why we need it:
In this PR, we enable users to exclude specific phases of their
choice during init/join command execution. This can be helpful in
cases like provisioning a cluster without kube-proxy deployed.

Note: This option takes effect only only on Kubernetes >=1.22.0.

Which issue(s) this PR fixes
Fixes #5357

[k8s-ci-robot]

Welcome @dntosas!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/ok-to-test

(will take a closer look later)

[sbueringer]

/retitle ✨ CABPK: Add support for kubeadm skipPhases field

[sbueringer]

@dntosas Change looks good so far. The next step is implementing conversion.
I think the following hackmd/video should explain a lot :)

• https://www.youtube.com/watch?v=Mk14N4SelNk
• https://hackmd.io/aYLvrb_jTXiwg_MnpD804w

Please take a look, but feel absolutely free to ask if there are any questions!

P.S. There are a few more videos about CAPI in general here: https://cluster-api.sigs.k8s.io/developer/guide.html?highlight=video#videos-explaining-capi-architecture-and-code-walkthroughs

[fabriziopandini]

@dntosas let me know if I can help somehow to get this moving
We are now back to normal after the release hype, so it should be easier to get maintainers cycles to get this merged

[dntosas]

@dntosas let me know if I can help somehow to get this moving We are now back to normal after the release hype, so it should be easier to get maintainers cycles to get this merged

Hey @fabriziopandini, was kinda busy last weeks. Will take a look today and reach out to you if needed so to move forwards with this :)

[dntosas]

@sbueringer @fabriziopandini i think we are better now :) fixed failing tests

[fabriziopandini]

Thanks for the update!
/lgtm

[jdef]

"Initonfiguration"?

[dntosas]

will push a fix in next hour(s) ☝️

[dntosas]

pushed ^^ thnx :)

[sbueringer]

Thanks looks good +/- the last nit above

[sbueringer]

Thank you very much!

/lgtm
/assign @fabriziopandini
for approval

[fabriziopandini]

this is a great first contribution @dntosas, thanks!
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/hold
/ok-to-test

[fabriziopandini]

/hold cancel

[aanoaa]

Note: This option takes effect only only on Kubernetes >=1.22.0.

This patch does not show depending on the kubernetes version.
Where can I found this effect?

And should the actual value used in skipPhases have the prefix such as addon?

      skipPhases:
        - addon/kube-proxy
        - kube-proxy

which one is right?
thanks

[aanoaa]

I found reference at here.

Add "InitConfiguration.SkipPhases", "JoinConfiguration.SkipPhases" to allow skipping a list of phases during kubeadm init/join command execution.

in kubeadm.k8s.io/v1beta3,

skipPhases:
  - addon/kube-proxy

is right thanks.