Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove omitempty tag from Machine.Spec.Taints #842

Closed
wants to merge 1 commit into from

Conversation

dlipovetsky
Copy link
Contributor

What this PR does / why we need it:
Allows the user to specify an empty set of taints (as opposed to specifying nothing at all).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #707

Special notes for your reviewer:
This is a breaking API change, please hold until after v1alpha1.

Remove `omitempty` tag from `Machine.Spec.Taints` field to allow users to specify an empty set of taints.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlipovetsky
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: kris-nova

If they are not already assigned, you can assign the PR to them by writing /assign @kris-nova in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlipovetsky
Copy link
Contributor Author

Breaking API change. Should not be merged until v1alpha1 release.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2019
@detiber
Copy link
Member

detiber commented Mar 21, 2019

/milestone Next

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Mar 21, 2019
@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cluster-api-test 657b2eb link /test pull-cluster-api-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@detiber
Copy link
Member

detiber commented Jun 19, 2019

Closing since we probably shouldn't modify the v1alpha1 types at this point. We should incorporate this into the v1alpha2 work, though.
/close

@k8s-ci-robot
Copy link
Contributor

@detiber: Closed this PR.

In response to this:

Closing since we probably shouldn't modify the v1alpha1 types at this point. We should incorporate this into the v1alpha2 work, though.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A provider cannot tell whether the user wants a Machine to have no taints, or whether the user does not care
3 participants