Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase CPA to distroless #56

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Rebase CPA to distroless #56

merged 1 commit into from
Apr 11, 2019

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Apr 11, 2019

This is part of the effort described in kep kubernetes/enhancements#900

This is part of the effort described in kep kubernetes/enhancements#900
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin April 11, 2019 23:02
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2019
@yuwenma
Copy link
Contributor Author

yuwenma commented Apr 11, 2019

/assign @MrHohn
/assign @erictune

@k8s-ci-robot
Copy link
Contributor

@yuwenma: GitHub didn't allow me to assign the following users: erictune.

Note that only kubernetes-incubator members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @MrHohn
/assign @erictune

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@MrHohn
Copy link
Member

MrHohn commented Apr 11, 2019

/hold
Will merge this once I verify locally.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2019
@MrHohn
Copy link
Member

MrHohn commented Apr 11, 2019

Seems to be working locally. Merging this.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit a47d1a4 into kubernetes-sigs:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants