add initial BucketClaim controller reconciliation #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
✅ Deploy Preview for container-object-storage-interface ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
size/XXL
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
from
696215f to
b938411
Compare
k8s-ci-robot
removed
the
needs-rebase
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
3 times, most recently
from
b276db2 to
b26e7f2
Compare
k8s-ci-robot
added
size/XL
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
2 times, most recently
from
437a8d2 to
4fc4441
Compare
k8s-ci-robot
added
size/XXL
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
3 times, most recently
from
4a2cf03 to
bfac155
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
2 times, most recently
from
6a87a7e to
ecce544
Compare
k8s-ci-robot
added
the
do-not-merge/work-in-progress
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
from
ecce544 to
941d700
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
4 times, most recently
from
40a92de to
3824046
Compare
BlaineEXE
commented
Oct 16, 2025
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:subresource:status | ||
| // +kubebuilder:resource:scope=Cluster | ||
| // +kubebuilder:metadata:annotations="api-approved.kubernetes.io=https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1979-object-storage-support" |
Contributor
Author
There was a problem hiding this comment.
TODO: look into this. This is supposed to be the PR that introduced a particular API change in code, not the KEP. There is some way to indicate that it is unapproved alpha/beta work that we should use instead.
Contributor
Author
There was a problem hiding this comment.
From KEP 1111, we should use a value beginning with unapproved instead of a link here. The KEP recommends including an explanation after.
I made the change to use api-approved.kubernetes.io=unapproved, experimental v1alpha2 changes, and I was able to install the CRDs in Minikube with no issues.
FYI: @xing-yang
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
from
3824046 to
23e5028
Compare
Add initial implementation for BucketClaim reconciliation based on v1alpha2 KEP. This initial implementation covers only the first section of Controller reconciliation for a new BucketClaim. Coverage ends at the point where reconciliation is handed off to the Sidecar. Signed-off-by: Blaine Gardner <blaine.gardner@ibm.com>
BlaineEXE
force-pushed
the
controller-bucketclaim-after-v1a2-skeleton
branch
from
23e5028 to
d587b32
Compare
Member
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlaineEXE, shanduur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial implementation for BucketClaim reconciliation based on
v1alpha2 KEP. This initial implementation covers only the first section
of Controller reconciliation for a new BucketClaim. Coverage ends at the
point where reconciliation is handed off to the Sidecar.